PMM-13534: Use platform address for version service #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoqo
requested review from
ademidoff and
BupycHuk
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #3306 +/- ##
==========================================
- Coverage 43.54% 43.53% -0.01%
==========================================
Files 366 366
Lines 44162 44169 +7
==========================================
- Hits 19232 19231 -1
- Misses 23249 23252 +3
- Partials 1681 1686 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
idoqo
commented
Nov 14, 2024
managed/services/server/updater.go
Outdated
| updateCheckResultFresh = updateCheckInterval + 10*time.Minute | ||
| updateDefaultTimeout = 30 * time.Second | ||
| envfilePath = "/home/pmm/update/pmm-server.env" | ||
| defaultLatestPMMImage = "perconalab/pmm-server:3-dev-latest" |
There was a problem hiding this comment.
I wonder if we should update this now to a stable version or wait till GA is released.
There was a problem hiding this comment.
is it still used somewhere in code?
There was a problem hiding this comment.
No even, dropped it now.
BupycHuk
approved these changes
Nov 14, 2024
managed/services/server/updater.go
Outdated
| updateCheckResultFresh = updateCheckInterval + 10*time.Minute | ||
| updateDefaultTimeout = 30 * time.Second | ||
| envfilePath = "/home/pmm/update/pmm-server.env" | ||
| defaultLatestPMMImage = "perconalab/pmm-server:3-dev-latest" |
There was a problem hiding this comment.
is it still used somewhere in code?
There is a possibility of nil (when we don't have any tag available). This updates the test to allow such cases and only check if latest is not nil
BupycHuk
reviewed
Nov 14, 2024
BupycHuk
reviewed
Nov 14, 2024
1 task
ademidoff
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13534
Link to the Feature Build: SUBMODULES-3767
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: